Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JP-3682: split outlier detection into separate steps for each mode #8722

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

JP-3682: split outlier detection into separate steps for each mode #8722

wants to merge 3 commits into from

Conversation

emolter
Copy link
Collaborator

@emolter emolter commented Aug 22, 2024

Resolves JP-3682
Resolves JP-3342

Closes #8634
Closes #7817

This PR addresses splitting outlier detection into separate steps for coronagraphy, IFU, imaging, spectroscopy, and TSO data. This was motivated by large differences in input parameters and algorithms that are implemented for each mode. The parallel separation of the documentation for those modes should also resolve the confusing structure of the docs for outlier detection.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@codecov Codecov
Copy link

codecov bot commented Aug 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 56.12648% with 111 lines in your changes missing coverage. Please review.

Project coverage is 60.39%. Comparing base (f6c4095) to head (32b8c51).
Report is 8 commits behind head on master.

Files Patch % Lines
...t/outlier_detection/outlier_detection_spec_step.py 28.57% 40 Missing ⚠️
...st/outlier_detection/outlier_detection_ifu_step.py 17.94% 32 Missing ⚠️
...utlier_detection/outlier_detection_imaging_step.py 81.48% 10 Missing ⚠️
...st/outlier_detection/outlier_detection_tso_step.py 67.85% 9 Missing ⚠️
jwst/pipeline/calwebb_spec3.py 11.11% 8 Missing ⚠️
.../outlier_detection/outlier_detection_coron_step.py 76.66% 7 Missing ⚠️
jwst/outlier_detection/utils.py 78.26% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8722      +/-   ##
==========================================
+ Coverage   60.38%   60.39%   +0.01%     
==========================================
  Files         372      371       -1     
  Lines       38337    38320      -17     
==========================================
- Hits        23148    23142       -6     
+ Misses      15189    15178      -11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emolter emolter added this to the Build 11.2 milestone Aug 22, 2024
@stscijgbot-jp stscijgbot-jp mentioned this pull request Aug 22, 2024
Open
@melanieclarke melanieclarke removed this from the Build 11.2 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
coron3 pipeline documentation image3 pipeline outlier_detection pipeline spec3 pipeline stpipe testing tso3 pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split OutlierDetectionStep into multiple steps Add documentation for outlier_detection
2 participants
@emolter @melanieclarke